[ 
https://issues.apache.org/jira/browse/TINKERPOP-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154362#comment-15154362
 ] 

ASF GitHub Bot commented on TINKERPOP-1153:
-------------------------------------------

Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/230#issuecomment-186262915
  
    Here is what I get in the console for that query:
    
    ```
    gremlin> g = TinkerFactory.createModern().traversal().withComputer()
    ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], 
tinkergraphcomputer]
    gremlin> g.V().hasLabel("software").has("name", 
"ripple").pageRank(1.0).by(__.inE("created")).times(1).by("priors").in("created").union(__.both(),
 __.identity()).valueMap("name", "priors")
    ==>[name:[marko], priors:[0.0]]
    ==>[name:[lop], priors:[0.0]]
    ==>[name:[josh], priors:[1.0]]
    ==>[name:[ripple], priors:[0.0]]
    gremlin>
    ```
    
    If someone who has a fail can tell me what they get that would help. 
However, again, I just commented out the test for now so I don't waste a day 
sitting here on an inanity.


> Add ByModulating and TimesModulating interfaces.
> ------------------------------------------------
>
>                 Key: TINKERPOP-1153
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1153
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.2-incubating
>            Reporter: Marko A. Rodriguez
>             Fix For: 3.2.0-incubating
>
>
> Currently {{GraphTraversal}} is responsible for the logic for {{by()}}- and 
> {{times()}}-modulators. For instance, if you do:
> {code}
> ...by('name')
> {code}
> It is {{GraphTraversal}} that will compile that to 
> {{__.values('name').limit(1)}}. This should not be the logic of 
> {{GraphTraversal}}, but instead, logic within the step being modulated. Thus, 
> I propose:
> {code}
> public interface ByModulating {
>   public void add(String string) throws UnsupportedOperationException
>   public void add(Traversal traversal) throws UnsupportedOperationException
>   public void add(T t) throws UnsupportedOperationException
> }
> {code} 
> Likewise for {{TimesModulating}} ... and any other modulators down the road.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to