Github user dkuppitz commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/230#issuecomment-186276300
  
    The error was only [reported by 
Travis](https://travis-ci.org/apache/incubator-tinkerpop/builds/110233907). I 
can't reproduce it on my local machine. I ran that particular query a few 
thousand times to see if this is going to be another random error, but the 
result seems to be consistent.
    
    * `mvn clean install`: passed
    * integration tests: passed
    
    I looked roughly over the code; looks good, but it's hard to grasp all the 
changes in 120 files, I could spend a whole day on it, hence ...
    
    VOTE: +0.5 (just to get at least one more reviewer for this PR)
    
    ```
    [INFO] Reactor Summary:
    [INFO] 
    [INFO] Apache TinkerPop .................................. SUCCESS [10.549s]
    [INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [5.610s]
    [INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS 
[1:05.941s]
    [INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [18.247s]
    [INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS [59.668s]
    [INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [14.663s]
    [INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS 
[9:36.751s]
    [INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS 
[12:24.137s]
    [INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS 
[26:11.246s]
    [INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS 
[2:59:20.410s]
    [INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS [11.686s]
    [INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS [28.561s]
    [INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS 
[12:02.678s]
    [INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS 
[1:56.698s]
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 4:05:07.482s
    [INFO] Finished at: Fri Feb 19 16:56:42 CET 2016
    [INFO] Final Memory: 62M/688M
    [INFO] 
------------------------------------------------------------------------
    ```
    
    ^^ That's for the previous version (before you excluded the test).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to