Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-186588044
You quoted the javadoc there and that's precisely my point about something
looking wrong. If my interpretation of that javadoc and the java source code
is correct, `awaitTermination` is returning false after blocking (due to
timeout), and you are just sleeping the thread for 30 seconds. which is plenty
of time for that work to finish. then you call a hard `shutdownNow` which has
no effect really because there are no more tasks executed. `awaitTermintation`
requires a call to `shutdown` somewhere for it to ever return true (success).
if this was a problem for appveyor I suggest you update your branch with
the latest changes which should have fixed the problems we were seeing with
this test:
https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutorTest.java#L634-L638
Let's see if appveyor is happy with that change before we go to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
