Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/242#issuecomment-188795098
A few things.
1. The name of the test is `ProfileTest.Traversals` not
`ProfileSideEffectTest.Traversals`. Its based on the `GraphTraversal.name()`,
not the underlying step. Likewise for `GroovyProfileTest.Traversals`. Thus, put
all those tests into one test suite. See how there is no
`GroupCountSideEffectTest.Traversals`, just `GroupCountTest.Traversals`.
2. Can you provide (as a comment here) the following -- UPGRADE
instructions for users and CHANGELOG notes. Don't do it in the code as merging
might suck. If you put it here, I can put it in on merge.
3. Can you verify that Giraph/Spark are happy?
Thanks @rjbriody
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
