+1 - integration tests typically mean "long" in our definition and one extra minute isn't really a hurt for local builds or CI
On Fri, Feb 26, 2016 at 10:35 AM, Marko Rodriguez <okramma...@gmail.com> wrote: > Hi, > > Bob Briody is doing some work on profile()-step and said: > > "SparkGraphComputerProcessIntegrateTest only takes about 30 > seconds to execute. Why is that integration testing?" > > I thought about it, and I agree. We already have various Spark tests that > are not integration-based. Would people object if I made both: > > SparkGraphComputerProcessIntegrateTest > SparkGraphComputerGroovyProcessIntegrateTest > > ----> > > SparkGraphComputerProcessTest > SparkGraphComputerGroovyProcessTest > > This will add about 1 minute to the "mvn clean install" but will be a lot > safer for people as lots of Serialization/VertexProgram Configuration/etc. > issues get exposed here that you don't see with > TinkerGraphComputerProcessTest. Definitely beneficial to people trying to > submit PRs. > > Thoughts?, > Marko. > > http://markorodriguez.com > >
