GitHub user xenji opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/246

    Make the GraphManager instance injectable into ServerGremlinExecutor

    This refers to a discussion from the gremlin-users mailing list:
    
[https://groups.google.com/forum/#!topic/gremlin-users/xYzCAQExvvM](https://groups.google.com/forum/#!topic/gremlin-users/xYzCAQExvvM)
    
    It is currently not possible to use a standard way to inject a
    fully configured graph. The way presented in this gist is only
    a hack and should not be takes as the default way.
    
[https://gist.github.com/xenji/e469abde2e0b80aadc4e](https://gist.github.com/xenji/e469abde2e0b80aadc4e)
    
    Adding a new constructor parameter is, from my point of view,
    the most flexible and compatible change to enable the injection
    without breaking old code.
    
    I've run the whole test suite of the server before pushing without
    failures.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xenji/incubator-tinkerpop 
make-graphmanager-injectable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 17c333410f3e2336810cf77620f8a2fa9164ddef
Author: Mario Mueller <mario.muel...@trivago.com>
Date:   2016-02-29T20:16:14Z

    Make the GraphManager instance injectable into ServerGremlinExecutor
    
    This refers to a discussion from the gremlin-users mailing list:
    https://groups.google.com/forum/#!topic/gremlin-users/xYzCAQExvvM
    
    It is currently not possible to use a standard way to inject a
    fully configured graph. The way presented in this gist is only
    a hack and should not be takes as the default way.
    https://gist.github.com/xenji/e469abde2e0b80aadc4e
    
    Adding a new constructor parameter is, from my point of view,
    the most flexible and compatible change to enable the injection
    without breaking old code.
    
    I've run the whole test suite of the server before pushing without
    failures.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to