Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197869261
oops - I was voting +1 without the understanding that this constituted a
breaking change. I figured the id magic issue might be sorted out separately,
but if this somehow breaks that, then I guess +1 was the wrong answer.
so - with that, i still don't fully understand where the break is. All the
old tests still pass don't they? Am I missing where you modified/removed the
tests that check for appropriate id semantics?
Perhaps the id magic is bad - it's already not perfect as you saw from
Daniel above - this issue details some of the problems with getting TinkerGraph
completely compliant:
https://issues.apache.org/jira/browse/TINKERPOP-1048
Maybe there's a better way to get the id semantics tests to pass than what
i'm doing in the `HasContainer`. I just don't know what it is offhand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
