[ 
https://issues.apache.org/jira/browse/TINKERPOP-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198102#comment-15198102
 ] 

ASF GitHub Bot commented on TINKERPOP-1219:
-------------------------------------------

Github user spmallette commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197536538
  
    I won't deny confusion, but I thought that you only get weird stuff with 
TinkerGraph when you use it in the default mode where types matter for the ids. 
 When you define an id manager, it returns expected results:
    
    ```text
    gremlin> conf = new BaseConfiguration()
    ==>org.apache.commons.configuration.BaseConfiguration@6273c5a4
    gremlin> 
conf.setProperty('gremlin.graph','org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph')
    ==>null
    gremlin> conf.setProperty('gremlin.tinkergraph.vertexIdManager','LONG')
    ==>null
    gremlin> graph = TinkerGraph.open(conf)
    ==>tinkergraph[vertices:0 edges:0]
    gremlin> TinkerFactory.generateModern(graph)
    ==>null
    gremlin> g = graph.traversal()
    ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
    gremlin> g.V(1).values("name")
    ==>marko
    gremlin> g.V().hasId(1).values("name")
    ==>marko
    gremlin> g.V("1").values("name")
    ==>marko
    gremlin> g.V().hasId("1").values("name")
    ==>marko
    ```
    
    I'm pretty sure that other graphs don't suffer this problem either - it's 
just the default type system of TinkerGraph that forces the expected type of 
the id to match..



> Create a test case that ensures the provider's compilation of g.V(x) and 
> g.V().hasId(x) is identical
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1219
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1219
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.1.1-incubating
>            Reporter: Mike Dias
>            Assignee: Marko A. Rodriguez
>            Priority: Minor
>              Labels: breaking, test
>             Fix For: 3.1.2-incubating
>
>
> As discussed in this topic: 
> https://groups.google.com/forum/#!topic/gremlin-users/Kz2bOeAeqh4
> It will ensure the same behavior between g.V().hasId(id) vs. g.V(id) and 
> graph.vertices(id)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to