[
https://issues.apache.org/jira/browse/TINKERPOP-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197367#comment-15197367
]
ASF GitHub Bot commented on TINKERPOP-1209:
-------------------------------------------
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/264#issuecomment-197348251
VOTE: +1
> ComparatorHolder should returns a Pair<Traversal,Comparator>.
> -------------------------------------------------------------
>
> Key: TINKERPOP-1209
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1209
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.1-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Labels: breaking
>
> Right now {{ComparatorHolder}} has a method:
> {code}
> List<Comparator> getComparators()
> {code}
> This should really be:
> {code}
> List<Pair<Traversal<?,E>,Comparator<E>>> getComparators()
> {code}
> By doing this, we will be able to order during the {{Memory}}-reduction in
> Gremlin OLAP. We will be able to create values that look like this:
> {code}
> [[32, "marko"], v[1]]
> [[12, "stephen"], v[7]]
> [[67, "daniel"], v[8]]
> ...
> {code}
> Then there will be an {{OrderBiOperator}} that will have a
> {{List<Compartor>}} that, for the example above, is size 2. It will then be
> able to use the already computed traversal ends to sort the vertices.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
