[ 
https://issues.apache.org/jira/browse/TINKERPOP-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206659#comment-15206659
 ] 

ASF GitHub Bot commented on TINKERPOP-1199:
-------------------------------------------

Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199883620
  
    This is ready to VOTE. The completed branch is actually TINKERPOP-1199 
locally (not in @rjbriody's repository anymore). I can't seem to make a PR from 
that our local branch as doing so just links me to this ticket. Don't know how 
that effects VOTERs and their testing ? --- just be aware.
    
    In short, profiling and the new sideEffect/memory model of GraphComputer 
have been reconciled. This was painful as profiling is a very 
complicated/intrusive system. However, getting it to work with the new 
memory-model in OLAP is a strong testament to the flexibility of the changes 
forthcoming in 3.2.0 OLAP. Bob and I added lots more testing as well. Also, 
there was a severe bug found in `ComputerVerificationStrategy` that has since 
been rectified (a profile test exposed it).
    
    CHANGELOG
    
    ```
    * Fixed a bug around profiling and nested traversals.
    ```
    
    VOTE +1.


> Use "MicroMetrics" as the mutator of the TraversalMetrics.
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1199
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1199
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Bob Briody
>             Fix For: 3.2.0-incubating
>
>
> This is a follow on to TINKERPOP-958. The idea is to mutate the global 
> {{TraversalMetrics}} using the {{TraversalSideEffects.add()}}-model.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to