[
https://issues.apache.org/jira/browse/TINKERPOP-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212639#comment-15212639
]
Bob Briody commented on TINKERPOP-1078:
---------------------------------------
In the PR there is some discussion about whether or not this ticket should
happen.
>From Marko
{quote}I really think we should keep all the information in there. I believe
(moving forward too) that explain() and profile() should have the same steps in
them. Meaning, we don't hide information to make it "look good." This means, in
OLAP, we need to make it so TraversalVertexProgramStep is shown, etc. We can do
all that moving forward and thus, I don't think this PR is good anymore (from
both a its so far behind from master/ and from a we should not hide steps
perspective).{quote}
It looks to me like .explain() does hide information. Notice that the
.explain() step is not included in the following print out:
{code}
gremlin> g.V().count().explain()
==>Traversal Explanation
================================================================================
Original Traversal [GraphStep(vertex,[]), CountGlobalStep]
ConnectiveStrategy [D] [GraphStep(vertex,[]), CountGlobalStep]
IdentityRemovalStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
MatchPredicateStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
IncidentToAdjacentStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
AdjacentToIncidentStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
RangeByIsCountStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
FilterRankingStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
OrderLimitStrategy [O] [GraphStep(vertex,[]), CountGlobalStep]
TinkerGraphStepStrategy [P] [TinkerGraphStep(vertex,[]), CountGlobalStep]
ProfileStrategy [F] [TinkerGraphStep(vertex,[]), CountGlobalStep]
StandardVerificationStrategy [V] [TinkerGraphStep(vertex,[]), CountGlobalStep]
Final Traversal [TinkerGraphStep(vertex,[]), CountGlobalStep]
{code}
...and that seems right to me. These steps are traversal diagnostics and should
be treated as such. Including them in explain/profile results would not be
valuable to the user.
In the case of profiling, including the profile steps will further interfere
with the information the user is actually interested in by contributing to the
total duration and % calculations. Note that we aren't "just hiding" the
profiling steps from output. We'll also exclude their duration so they don't
screw up the grand totals.
{quote}in OLAP, we need to make it so TraversalVertexProgramStep is shown,
etc.{quote}
Agreed, but that's a separate bug/insufficiency.
> Do not include TraversalMetrics cap in profile results.
> -------------------------------------------------------
>
> Key: TINKERPOP-1078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1078
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.1-incubating
> Reporter: Bob Briody
> Labels: breaking
> Fix For: 3.2.0-incubating
>
>
> _As a user profiling a traversal, I am likely to cap the TraversalMetrics
> results, but I don't actually want that Step included in my profile._
> When the TraversalMetrics are cap'd off the end of the traversal the .cap()
> Step should be excluded from the metrics and timers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
