[ 
https://issues.apache.org/jira/browse/TINKERPOP-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212797#comment-15212797
 ] 

ASF GitHub Bot commented on TINKERPOP-1236:
-------------------------------------------

Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/277#issuecomment-201704483
  
    This is a failure from another PR that wasn't full integration tested. This 
is not related to this PR.
    
    ```
    
shouldSerializeTree(org.apache.tinkerpop.gremlin.structure.SerializationTest$GraphSONTest)
  Time elapsed: 0.206 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<1> but was:<0>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at 
org.apache.tinkerpop.gremlin.structure.SerializationTest$GraphSONTest.shouldSerializeTree(SerializationTest.java:385)
    
    Running 
org.apache.tinkerpop.gremlin.neo4j.structure.NoMultiNoMetaNeo4jGraphStructureStandardTest
    Tests run: 799, Failures: 1, Errors: 0, Skipped: 266, Time elapsed: 216.4 
sec <<< FAILURE! - in 
org.apache.tinkerpop.gremlin.neo4j.structure.NoMultiNoMetaNeo4jGraphStructureStandardTest
    
shouldSerializeTree(org.apache.tinkerpop.gremlin.structure.SerializationTest$GraphSONTest)
  Time elapsed: 0.152 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<1> but was:<0>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at 
org.apache.tinkerpop.gremlin.structure.SerializationTest$GraphSONTest.shouldSerializeTree(SerializationTest.java:385)
    
    
    Results :
    
    Failed tests:
      SerializationTest$GraphSONTest.shouldSerializeTree:385 expected:<1> but 
was:<0>
      SerializationTest$GraphSONTest.shouldSerializeTree:385 expected:<1> but 
was:<0>
    ```


> SelectDenormalizationStrategy for select().by(starGraph) in OLAP.
> -----------------------------------------------------------------
>
>                 Key: TINKERPOP-1236
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1236
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.1-incubating
>            Reporter: Marko A. Rodriguez
>
> Right now, if you do anything beyond {{select().by(id)}} in OLAP, you get a 
> {{PathProcessor can't go beyond ElementRequirements.ID}}-style exception. 
> This is TOTALLY unacceptable (like totally... I know right.) because 
> {{select()}} is so heavily used that it makes the OLAP experience not so 
> bueno.
> Enter -- {{SelectDenomalizationStrategy}} which will only be used in OLAP 
> compilations.
> {code}
> select("a").by("name") // not allowed in OLAP right now. (1)
> select("a").map(values("name")) // allowed in OLAP. (2)
> {code}
> Thus, compile (1) into (2). However, in a {{while(true)}}-loop until 
> {{boolean fullyDenormalized}} you also check on this pattern:
> {code}
> select("a","b").by(outE().count()).by("name") // not allowed in OLAP right 
> now (1)
> select("a").by(outE().count()).as("a").select("b").by("name").as("b").select("a","b",Pop.last)
>  // not allowed in OLAP right now, but this denormalizes again given the 
> first SelectOne pattern
> {code}
> The only problem with this is that future {{select()}} will {{Pop}} a list. 
> We need to really make it so we can drop path labels. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to