[ 
https://issues.apache.org/jira/browse/TINKERPOP-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215830#comment-15215830
 ] 

ASF GitHub Bot commented on TINKERPOP-1223:
-------------------------------------------

Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/282#discussion_r57703975
  
    --- Diff: 
hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/process/computer/AbstractHadoopGraphComputer.java
 ---
    @@ -195,4 +202,27 @@ public boolean supportsDirectObjects() {
                 return false;
             }
         }
    +
    +    //////////
    +
    +    public static File copyDirectoryIfNonExistent(final FileSystem 
fileSystem, final String localDirectory) {
    +        try {
    +            final String hadoopGremlinLibsRemote = "hadoop-gremlin-" + 
Gremlin.version() + "-libs";
    +            File file = new File(localDirectory);
    +            if ((Boolean.valueOf(System.getProperty("is.testing", 
"false")) || !file.exists()) && fileSystem.exists(new Path(localDirectory)) && 
fileSystem.isDirectory(new Path(localDirectory))) {
    +                final File tempDirectory = new 
File(System.getProperty("java.io.tmpdir") + "/" + hadoopGremlinLibsRemote);
    --- End diff --
    
    Please replace hardcoded path separator with platform independent call to 
`System.getProperty("file.separator")`


> Allow jars in gremlin.distributedJars to be read from HDFS
> ----------------------------------------------------------
>
>                 Key: TINKERPOP-1223
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1223
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: hadoop
>    Affects Versions: 3.2.0-incubating
>            Reporter: Matthias Broecheler
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.2.0-incubating
>
>
> in addition to the local file system as it currently stands. That makes it 
> possible for users to include custom VertexPrograms in their OLAP traversals 
> when they don't have local file access to the compute machines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to