Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/288#issuecomment-206806234
So you're saying that there is some case where
`threadLocalTx.get().close();` fails in the `finally` clause and then we don't
get a nice call to `threadLocalTx.remove();`. Doesn't your change introduce a
new problem though, where a fail on a call to `threadLocalTx.get().success();`
or `threadLocalTx.get().failure();` would mean that
`threadLocalTx.get().close();` would never get called?
Also, is this only a problem for 3.2.0? seems like this fix should be
targetted at 3.1.2 and the tp31 branch, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
