Well those are unit tests (so yes - non-integration tests). What I just noticed though is that this configuration is for the appveyor windows build. As you say, I think we should just leave it unless Marvin Froeder says otherwise..
On Tue, Apr 12, 2016 at 9:22 AM, Marko Rodriguez <okramma...@gmail.com> wrote: > Hi Stephen, > > What is this "excluding" ? This is for non-integration tests? > > I believe that I made it so that only > SparkGraphComputerProcessIntegrateTest ran to reduce the time it took for > "mvn clean install" to do its thing. I would just leave both for now as you > have it and if we want to make "mvn clean install" faster, we can remove > the SparkGraphComputerGroovyProcessIntegrateTest. > > Marko. > > http://markorodriguez.com > > On Apr 12, 2016, at 4:52 AM, Stephen Mallette <spmalle...@gmail.com> > wrote: > > > Yesterday I flubbed a merge from tp31 to master. I know exactly what I > did > > and the merge was not all that complicated so luckily it was quite easy > to > > resolve. The only thing that possibly remains amiss are these two lines > in > > the spark-gremlin pom.xml: > > > > > https://github.com/apache/incubator-tinkerpop/blob/bbf6b19cdd62952a086cf6902847a3352e107bd9/spark-gremlin/pom.xml#L413-L414 > > > > These two lines were in tp31 but not in master at the time of this merge. > > They are now in master and i'm not sure if they should be. Marko, as > this > > is spark related, I assume that you would know whether they should be > only > > in tp31 or not - if so, let me know and I'll remove them from master. > > > > Thanks, > > > > Stephen > >
