Github user mike-tr-adamson commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/291#issuecomment-211867447
  
    I have changed the ```Handler::channelRead0``` to add the mechanism as an 
argument to the initial SASL message. These means that the 
```SaslAuthenticationHandler``` is now unchanged. 
    
    I agree that this is a more elegant solution and allows 3rd party auth 
implementations to use or not use the mechanism at their leisure. Note that it 
is down to the auth implementation to handle the case of no mechanism being 
passed. It shouldn't be a requirement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to