[ 
https://issues.apache.org/jira/browse/TINKERPOP-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265358#comment-15265358
 ] 

ASF GitHub Bot commented on TINKERPOP-946:
------------------------------------------

Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-215977029
  
    I don't think you need to put as may interrupt checks. Most steps inherit 
from `AbstractStep` and thus, if `AbstractStep.next()` and 
`AbstractStep.hasNext()` have the interrupt check, then all the 
`processNextStart()` in subclasses don't need to check for the interrupt. This 
should greatly reduce the amount of classes touched and requirements on 
providers with their own step implementations. In short, they just need to make 
sure they extend `AbstractStep`. However, with that said, I still think you 
need the `VertexProgramStep` work in there as you have it.


> Traversal respecting Thread.interrupt()
> ---------------------------------------
>
>                 Key: TINKERPOP-946
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-946
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.2.1
>
>
> This issue was discussed to some degree here:
> https://pony-poc.apache.org/thread.html/e6477fc9c58d37a5bdcb5938a0eaa285456ad15aa39e16446290e2ff@1444993523@%3Cdev.tinkerpop.apache.org%3E
> There's a good half-way solution in all this that balances performance with 
> the desired capability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to