When we want use different Handler it was easier we
don't create the ConnectionHandler inside constructor.

Can we use a init() method instead?
   protected Http11ConnectionHandler createConnectionHandler() {
... }

   public void init() throws Exception {
       cHandler = createConnectionHander() ;
       ep.setConnectionHandler( cHandler );

Can you please test my last checkin?

Peter

Costin Manolache schrieb:

On 11/12/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: pero
Date: Sat Nov 12 04:29:58 2005
New Revision: 332766

URL: http://svn.apache.org/viewcvs?rev=332766&view=rev
Log:
Fix that the RequestProcessor registered at JMX.
It was nice to see this information back inside manager app :-)


tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11BaseProtocol.java
Sat Nov 12 04:29:58 2005
@@ -54,11 +54,6 @@
public class Http11BaseProtocol implements ProtocolHandler
{
    public Http11BaseProtocol() {
-        cHandler = new Http11ConnectionHandler( this );
-        setSoLinger(Constants.DEFAULT_CONNECTION_LINGER);
-        setSoTimeout(Constants.DEFAULT_CONNECTION_TIMEOUT);
-        setServerSoTimeout(Constants.DEFAULT_SERVER_SOCKET_TIMEOUT);
-        setTcpNoDelay(Constants.DEFAULT_TCP_NO_DELAY);
    }

    /**
public class Http11Protocol extends Http11BaseProtocol implements 
MBeanRegistration
{
    public Http11Protocol() {
-        super();
+        cHandler = new JmxHttp11ConnectionHandler( this );
+        setSoLinger(Constants.DEFAULT_CONNECTION_LINGER);
+        setSoTimeout(Constants.DEFAULT_CONNECTION_TIMEOUT);
+        setServerSoTimeout(Constants.DEFAULT_SERVER_SOCKET_TIMEOUT);
+        setTcpNoDelay(Constants.DEFAULT_TCP_NO_DELAY);
    }



Can we have the setSoLinger, etc in the base as well ? After this
change, the base is probably broken - I'm using it as non-jmx,
standalone http connector.
Maybe in an init function - overriden ?


Costin

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]









---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to