On 11/21/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > I hope you are not serious... Sorry if I sounded too critical of the > > APR code - it is a great > > piece of code in many ways, I just didn't like some (probably minor) things. > > Ok, but it helped make me realize I should maintain my own tree anyway, > since my plans are a bit opposed to your refactoring. Also, I have > medium term requirements which most likely are going to not fit with > what Tomcat needs :(
Well, my need is the sandbox - so I can experiment and understand the many things that happened in the last years. I didn't propose any major refactoring or new requirements - I might need 2-3 lines of code changed in the main branch for single-jar ( it works now with the main branch as is, but it's not perfect ). For NIO - all I want is to see for myself how it works and what it can do. That's what the sandbox is supposed to do. If you want to maintain your own tree and have some new requirements - say so, and maybe they can go in the main branch, or maybe if they are extremely unusual ( I doubt ) in sandbox. > > Yes, I guess I shouldn't complain too much about code which is being > designed in the sandbox, sorry about that :) Again, 'designed' is a too strong word. "Toyed with" maybe. > > > I don't like 'alghoritms that behave in sublty different ways', or > > duplicating extremely complex > > classes just for 3-4 lines of code that is different. I know it is > > simpler to write and probably maintain the code ( for people who wrote > > it ), but not easier to understand for me. > > Yes, I understand that, but for me the algorithm is already a bit > complex since, although it looks similar, the process method is > completely different. Hopefully, it has no bugs right now ! Everything has bugs :-) Yes, that is my point - it looks similar, but I had problems to understand the differences. It's not about comments or documentation - but about the code organization, looking at the diffs was my only way to understand. Again, I don't want to touch something that works - just to understand, and maybe create a similar prototype using NIO. Or maybe a smaller APR connector that I can play with in 'coyote standalone' mode ( I want to keep it as small as possible ). Or maybe try to write a small NIO provider using APR ( and put to rest this debate about what is better ). I don't know - just want to play in the sandbox :-) Costin --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
