Haroon Rafique wrote:

Replace:
copy(localWar, new File(getAppBase(), basename + ".war"));

with:

File secondCopy = new File(getAppBase(), basename + ".war");
if( !localWar.getCanonicalPath().equals(secondCopy.getCanonicalPath()) ) {
        copy(localWar, secondCopy);
}


exactly, this or a better fix: do this check inside the copy method.

BASE vs HOME was just an example of a scenario that you didn't think about, there are many more. so a patch should not break, but improve. just like the one you suggested, all you have to do now is to submit the actual patch file

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to