OK, I have no real problem to made my changes at 6.0 base first, but
it is really stable?
I see that Connector change currently and this can be a problem.
Quick integration tests with connector that are new is not
funny. What are the next developing steps at 6.0? It is the right
time to change the manager and session base classes.
Proposed changes:
- Remove all direct method/code duplications at the DeltaManager/
DeltaSession subclasses
- analyse, at example the listener methods with a lot of code
duplications.
- extract some helper methodes at base classes for eaisier subclassing.
- factor out the DeltaManager sender and receiver methods.
- DeltaManager and DeltaSession at cluster and ha modules are very
similar and porting is currently no problem.
I also plan to wrote some junit testcase. I don't want change any
functionality and refactor at small steps.
Peter
Am 24.04.2006 um 18:24 schrieb Rainer Jung:
Peter Rossbach wrote:
Yes, thing a real refactoring must start at ManagerBase. Then we
get a better interface for easier subclassing Manager like
DeltaManager at existing cluster and ha modules and other
implementation like JBoss.
I thing we have now some options:
a) Refactoring at tomcat 5.5 later port to 6.0
b) Refactoring at tomcat 6.0 later backport to 5.5
c) no refactoring
I vote for a) +1
Peter
For me the right choice would depend on the size and risk of the
refactoring. 5.5 is assumed to be pretty stable now. So I would
have a tendency to vote for b) unless I get a better idea about how
small and well-understood the changes would be.
Peter: since you think a) is the way to go: could you point out,
what the amount of changes would be?
Thanks!
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
