Author: markt
Date: Tue Sep 15 13:55:27 2015
New Revision: 1703198
URL: http://svn.apache.org/r1703198
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58385
Fix a rare data race in the internal flag Tomcat uses to keep track of whether
or not a request is being used for Comet processing.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=1703198&r1=1703197&r2=1703198&view=diff
==============================================================================
--- tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java
(original)
+++ tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Request.java Tue
Sep 15 13:55:27 2015
@@ -233,9 +233,9 @@ public class Request
/**
- * Comet state
+ * Comet state (can be accessed from multiple threads concurrently).
*/
- protected boolean comet = false;
+ protected volatile boolean comet = false;
/**
Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1703198&r1=1703197&r2=1703198&view=diff
==============================================================================
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Tue Sep 15 13:55:27 2015
@@ -95,6 +95,11 @@
implementation on the flag that tracks if the session is new and on the
field that tracks the maximum inactive period. (markt)
</fix>
+ <fix>
+ <bug>58385</bug>: Fix a rare data race in the internal flag Tomcat uses
+ to keep track of whether or not a request is being used for Comet
+ processing. (markt)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
