On 8/11/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
3. public boolean read(HttpServletRequest request, HttpServletResponse
response)
Suggestion - change this method to
public boolean event(CometEvent event)
This will allow the container to implement notifications for
timeouts, socket close, and read events through a single channel.
Easier to add future events and/or more fine grained events
4. public boolean error(HttpServletRequest request, HttpServletResponse
response)
Suggestion - remove this method, as it can be replaced with the event
method.
If we do want to keep this method, lets include a little bit more info
about the error, is it a timeout or a socket close, or an in process
exception etc
Hmm.. having just the event() does seem useful.
End users such as myself would not be certain if error handling logic
is better written inside error() or inside read().
With just a single event(), I find I can draw parallels to the doPost
that we have in the JavaServlet spec.
A +1 from an end user for the API change suggestions.
-- Sriram
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
