-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 All,
On 1/18/16 5:30 AM, Mark Thomas wrote: > On 18/01/2016 09:24, Rémy Maucherat wrote: >> 2016-01-18 10:17 GMT+01:00 <ma...@apache.org>: >> >>> Author: markt Date: Mon Jan 18 09:17:13 2016 New Revision: >>> 1725201 >>> >>> URL: http://svn.apache.org/viewvc?rev=1725201&view=rev Log: >>> Refactor handling of failed loading of persisted sessions. Old >>> behaviour: - sessions loaded up to point where error occurred - >>> serialized session data deleted - web app started i.e. session >>> data after the failure was lost New behaviour - serialized >>> session data deleted only if all sessions loaded without error >>> - web application only starts if all sessions loaded without >>> error >>> >> Honestly I'm not a big fan of session saving, I consider it >> causes as much issues as it does resolve. But as a result, I >> think it should be best effort, so I prefer the old behavior. > > My concern with the old behaviour was if something transient went > wrong (no specific example, this has always just worked for me) > then the system admin has no chance to correct it before the file > is deleted. That seemed worse to me than the web application not > starting. > > Then again, maybe the right answer is to document that this will be > on a best efforts basis and if the user wants a more robust > solution they should use the PersistentManager (which persists on a > session by session basis so if one session fails it doesn't impact > the others and the data that failed to load is retained). > > I do have a slight preference for this change but I am happy to > revert and make the docs changes I suggest above instead if that is > what people would prefer. I'd prefer the "fail to launch" behavior. The admin can rm the file and restart if that's the behavior they want. Or not enable it in the first place. If Tomcat eats the session file, there is no recourse. - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlaekzAACgkQ9CaO5/Lv0PBAAwCfXpbYsVS55YRArTObOODrdsZ4 MegAnAgIdqA3lZY4jiZt5+f0SGiBCWu8 =Zl4D -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
