On 20/01/2016 16:07, Mark Thomas wrote: > On 20/01/2016 12:56, Konstantin Kolinko wrote: >> 2016-01-20 15:21 GMT+03:00 <ma...@apache.org>: >>> Author: markt >>> Date: Wed Jan 20 12:21:26 2016 >>> New Revision: 1725706 >>> >>> URL: http://svn.apache.org/viewvc?rev=1725706&view=rev >>> Log: >>> Don't need to bind the thread when saving sessions. Classes already have >>> the necessary reference to their class loader. >>> >>> Modified: >>> tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java >> >> -1. You must set Thread Context ClassLoader when calling application code. >> >> An application class can have custom implementation of >> serialization/externalization. It can perform logging. TCCL is needed >> for that. > > Drat. I thought I have thought through all the angles here but I missed > logging. I'll get that restored. I need to check all the code paths that > call unload. I may end up setting the TCCL elsewhere.
The other paths all set the TCCL so I reverted this patch. Thanks for the review. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
