On 05/02/2016 17:54, Rémy Maucherat wrote: > 2016-02-05 18:28 GMT+01:00 Mark Thomas <ma...@apache.org>: > >> Ah. Not sure how I managed to get confused on this. The name makes >> perfect sense in that case. >> > It must be a bad name for the flag since you got confused by what it does, > so you can change it. I objected because the proposed name was wrong. > Ideas: useAprConnector (not that good, the connector can still be used even > if the flag is false), aprConnectorAsDefault (maybe, but a bit long), > defaultToAprConnector (sounds average).
I think the name is fine. What confused me was that when I wasn't sure what it did I reviewed the code and the code wasn't quite right in all cases. I've just fixed that. I think we are good now (assuming you agree my fixes are correct). Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
