Author: violetagg
Date: Mon Apr 4 12:04:38 2016
New Revision: 1737664
URL: http://svn.apache.org/viewvc?rev=1737664&view=rev
Log:
Ensure the exceptions caused by Valves/Authenticators will be available in the
log files so that they can be evaluated when
o.a.catalina.valves.ErrorReportValve.showReport=false. Patch is provided by
Svetlin Zarev via mailing list
http://marc.info/?l=tomcat-user&m=145951730303576&w=2
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1737664&r1=1737663&r2=1737664&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Mon Apr
4 12:04:38 2016
@@ -147,13 +147,10 @@ final class StandardHostValve extends Va
}
} catch (Throwable t) {
ExceptionUtils.handleThrowable(t);
+ container.getLogger().error("Exception Processing " +
request.getRequestURI(), t);
// If a new error occurred while trying to report a previous
- // error simply log the new error and allow the original error
- // to be reported.
- if (response.isErrorReportRequired()) {
- container.getLogger().error("Exception Processing " +
- request.getRequestURI(), t);
- } else {
+ // error allow the original error to be reported.
+ if (!response.isErrorReportRequired()) {
request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, t);
throwable(request, response, t);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1737664&r1=1737663&r2=1737664&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Apr 4 12:04:38 2016
@@ -96,6 +96,12 @@
attributes in WebServlet and WebFilter annotations is not allowed.
(violetagg)
</fix>
+ <fix>
+ Ensure the exceptions caused by Valves will be available in the log
+ files so that they can be evaluated when
+ <code>o.a.catalina.valves.ErrorReportValve.showReport</code> is
+ disabled. Patch is provided by Svetlin Zarev. (violetagg)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
