https://bz.apache.org/bugzilla/show_bug.cgi?id=59699

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
(In reply to bdahon from comment #2)
> Hi,
> 
> For what I've read, you modified the findClass method to lookup resources
> before actually loading the class. Reading your comments in the code, it's
> faster.

That wasn't the only change.

> However, it doesn't actually cache the results, no ?

No additional caching was introduced.

> Wouldn't it be better to actually cache the results ?

No idea.

A thread-safe, memory leak free cache would add a reasonable amount of
complexity. There are no guarantees it would be faster.

Suitable cache settings will vary between applications so that may require per
web application configuration - something that is particularly complex for a
specification class where we can't change the public API.

If a specific performance issue is raised against the latest code (with a test
case that demonstrates the issue) we'll take another look but at this point the
code is viewed as 'good enough'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to