On 17/11/2016 09:06, Violeta Georgieva wrote: > Hi, > > There is an issue [1] about an incorrect javadoc > for org.apache.catalina.AccessLog.setRequestAttributesEnabled > > I have a question about the default value. > > With the following change [2], back in 2011, the default for all > implementations was set to "true". > But with change [3] the default value, only for AccessLogValve, was set to > "false". > > Was that intentional?
Based on my commit comments I believe the change was deliberate. > If yes than I will remove the default value definition from the interface > and I will extend the java doc for the implementations with the concrete > default value. +1 Thanks, Mark > > > Thanks, > Violeta > > [1] http://marc.info/?l=tomcat-dev&m=147936375104497&w=2 > [2] > https://github.com/apache/tomcat/commit/0dc6dbef18d8277037fa2023b76d9bb444622b32 > [3] > https://github.com/apache/tomcat/commit/98b583e5cfdd0250c3a7a24f85ce2963f9f8ca72 > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
