https://bz.apache.org/bugzilla/show_bug.cgi?id=60381

--- Comment #4 from Mark Thomas <ma...@apache.org> ---
(In reply to Michael Osipov from comment #3)

> Don't you think it is worthwile to port back to 8.5?

No.

> Do you think that the simple class name is sufficient?

Yes.

> I have noticed that a lot of components which use Container do not implement
> Contained at all. Is there a legacy reason for that? It seems awkward.

It was added to solve a specific problem for Valves. It wasn't added to the
other components because it wasn't required.

> It might be worth considering deprecating RealmBase#getName() since only
> toString() uses it and it is likely to be superseded.

+1.

> Moreover, toString() has to be well crafted if it is used in MBeans/JMX or
> log statements to clearly identify the component itself and its location in
> the server tree.

JMX name generation should be separate from toString().

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to