Author: markt
Date: Fri Nov 25 20:57:24 2016
New Revision: 1771386
URL: http://svn.apache.org/viewvc?rev=1771386&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60395
Log when an Authenticator passes an incomplete GSSContext to a Realm since it
indicates a bug in the Authenticator.
Patch provided by Michael Osipov.
Modified:
tomcat/trunk/java/org/apache/catalina/realm/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/realm/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/LocalStrings.properties?rev=1771386&r1=1771385&r2=1771386&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/realm/LocalStrings.properties Fri Nov
25 20:57:24 2016
@@ -73,6 +73,7 @@ realmBase.createUsernameRetriever.Instan
realmBase.createUsernameRetriever.IllegalAccessException=Cannot create object
of type {0}.
realmBase.credentialHandler.customCredentialHandler=Unable to set the property
[{0}] to value [{1}] as a custom CredentialHandler has been configured
realmBase.cannotGetRoles=Cannot get roles from principal [{0}]
+realmBase.gssContextNotEstablished=Authenticator implementation error: the
passed security context is not fully established
userDatabaseRealm.lookup=Exception looking up UserDatabase under key {0}
userDatabaseRealm.noDatabase=No UserDatabase component found under key {0}
dataSourceRealm.authenticateFailure=Username {0} NOT successfully authenticated
Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=1771386&r1=1771385&r2=1771386&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Fri Nov 25
20:57:24 2016
@@ -509,6 +509,8 @@ public abstract class RealmBase extends
}
return getPrincipal(name, gssCredential);
}
+ } else {
+ log.error(sm.getString("realmBase.gssContextNotEstablished"));
}
// Fail in all other cases
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1771386&r1=1771385&r2=1771386&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Nov 25 20:57:24 2016
@@ -118,6 +118,12 @@
return value. (markt)
</scode>
<fix>
+ <bug>60395</bug>: Log when an <code>Authenticator</code> passes an
+ incomplete <code>GSSContext</code> to a Realm since it indicates a bug
+ in the <code>Authenticator</code>. Patch provided by Michael Osipov.
+ (markt)
+ </fix>
+ <fix>
<bug>60400</bug>: When expanding the buffer used for reading the
request body, ensure the read position will be restored to the
original one. (violetagg)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
