https://bz.apache.org/bugzilla/show_bug.cgi?id=60596
Bug ID: 60596
Summary: Improve performance of DefaultServlet.checkSendfile()
when SendFile feature is disabled on a connector
Product: Tomcat 9
Version: 9.0.0.M17
Hardware: PC
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: knst.koli...@gmail.com
Target Milestone: -----
Reviewing SendFile support in DefaultServlet,
the feature is implemented with the following code in current trunk:
// method DefaultServlet.checkSendfile()
if (sendfileSize > 0
&& resource.isFile()
&& length > sendfileSize
&& (resource.getCanonicalPath() != null)
&&
(Boolean.TRUE.equals(request.getAttribute(Globals.SENDFILE_SUPPORTED_ATTR)))
&&
(request.getClass().getName().equals("org.apache.catalina.connector.RequestFacade"))
&&
(response.getClass().getName().equals("org.apache.catalina.connector.ResponseFacade")))
{
request.setAttribute(Globals.SENDFILE_FILENAME_ATTR,
resource.getCanonicalPath());
Notes:
1. It is better to check for
request.getAttribute(Globals.SENDFILE_SUPPORTED_ATTR) flag first.
Calling resource.isFile() and resource.getCanonicalPath() incurs I/O processing
that is not needed when send file feature is disabled on a Connector.
2. resource.getCanonicalPath() is calculated twice. First time to check that it
is not null, second time to set SENDFILE_FILENAME_ATTR attribute.
In general, all this activity will be followed by File I/O, so performance
improvement may be small compared to the rest of I/O.
Duplicate evaluation of getCanonicalPath() is not a matter for Tomcat 7 and
earlier, as in the old JNDI implementation of resources the value of canonical
path is cached (see
org.apache.naming.resources.FileResourceAttributes.getCanonicalPath()).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
