Hi Konstantin, Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit :
> 1. Please update xdocs/miscellaneous/changelog.xml as well. Thanks I didn't see it. > 2. I see that other "able-" flags use AS_HELP_STRING() macro to format > help string. > > Maybe use it here as well? I got a look and they seem fine since they already use ${enableval}. > 3. Don't forget to add youself to the list at Tomcat site > http://tomcat.apache.org/whoweare.html > > See README.txt in the site source directory, > https://svn.apache.org/repos/asf/tomcat/site/trunk/ Done. Thank you for the review. Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org