On 30/01/2017 19:49, Christopher Schultz wrote: > Mark, > > On 1/27/17 4:02 PM, ma...@apache.org wrote: >> Author: markt >> Date: Fri Jan 27 21:02:08 2017 >> New Revision: 1780609 >> >> URL: http://svn.apache.org/viewvc?rev=1780609&view=rev >> Log: >> Follow-up to r1780606 >> Ensure RFC2109 cookie is created with correct version >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java >> tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java >> >> Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java?rev=1780609&r1=1780608&r2=1780609&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java >> (original) >> +++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/Cookie.java Fri Jan >> 27 21:02:08 2017 >> @@ -145,7 +145,7 @@ public class Cookie { >> skipLWS(bb); >> byte b = bb.get(); >> if (b == SEMICOLON_BYTE || b == COMMA_BYTE) { >> - parseCookieRfc2109(bb, serverCookies); >> + parseCookieRfc2109(bb, serverCookies, version - 48); > > Would it be more self-documenting to subtract '0' instead of 48, there?
Probably better still to do the offset when the byte is read. I'll fix that in a sec. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
