On 08/02/17 15:53, Violeta Georgieva wrote:
2017-02-07 23:54 GMT+02:00 Violeta Georgieva <violet...@apache.org>:
2017-02-07 23:44 GMT+02:00 Mark Thomas <ma...@apache.org>:
On 06/02/17 20:35, Violeta Georgieva wrote:
Hi,
With the current implementation if there is AuthConfigProvider we will
initialize it once and then we will use it. However if such
AuthConfigProvider is not available, on every request we will spend
time in
redundant search operation to find AuthConfigProvider that is not
available.
What do you think about moving AuthConfigProvider initialization while
constructing the authenticator?
Won't that break web applications that initialize their own JASPIC
configuration on web application start?
:( most probably
If performance is a concern we could store a static constant NO-OP
AuthConfigProvider in jaspicProvider if no provider is available and then
check for that on subsequent calls and return null if we find it. That
should be marginally quicker than the repeating the lookup.
+1
What do you think about this approach?
https://github.com/apache/tomcat/pull/43
That is pretty much what I had in mind although I didn't use an Optional.
Committed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
