> > I recommend using the code coverage reports as a guide. > > https://ci.apache.org/projects/tomcat/tomcat9/coverage/
> > and add test cases if they increase code coverage. Hmm. It looks like > there is some low hanging fruit in the parsing code to improve coverage. > > You can run the tests with code coverage locally too. > Thank you for the guidance, I'll add only these test cases that increases code coverage. > Other than that, the usual advice applies. Test limits, either side of > limits, etc > > Generally, I try and reduce copy and paste as much as possible. @RunWith > has been really good for that. There is probably scope to use it more > throughout the Tomcat tests. > > Kind regards, > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > Is there an issue tracking this change where I can attach the patch when I'm ready? Or should I do so here? Thank you, Katya
