Hi guys, a quick feedback on that topic:
- github seems to be the preferred way to submit code these days (what we saw in tomee, batchee etc), it implies almost the same amount of work for dev (just need to comment if applied or not on github itself for tracking) so it is a good way probably - tomcat build not being "standard" can be a stopper for newcomers, I know migrating to a real maven structure was rejected multiple times but I think it can help. It would enable to import the project smoothly in any IDE, run it almost directly from the command line (it is not rare now to not have ant), and make it easier to browse the structure/package/module Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://blog-rmannibucau.rhcloud.com> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory <https://javaeefactory-rmannibucau.rhcloud.com> 2017-06-01 15:29 GMT+02:00 Mark Thomas <ma...@apache.org>: > On 1 June 2017 13:05:18 BST, Coty Sutherland <csuth...@redhat.com> wrote: > > >Hm, using Git was mentioned at the TomcatCon but I can't recall if the > >git repository on github is bi-directional or just a clone of svn. Can > >anyone answer that? > > The ASF hosts a read-only git clone of svn. GitHub has a read-only mirror > of the ASF repo. > > I.e. only ASF svn is read/write. > > > Have we made a decision about the best way to > >submit patches? BZ attachment, github PR, email, other? > > BZ or PR are generally best since they are less likely to be forgotten. > > > How often do > >we check the github projects for contributions? > > Notifications of PRs get sent to the dev list. > > > We also talked about > >going over the tomcat 6 and older version BZs to clean them up, maybe > >we should do the same for github PRs? > > 5.5.x and earlier was cleaned up as they went EOL. There are currently 15 > or so 6.0.x BZ entries left to clean up. > > >> Anyway, there are PRs there from a few months ago, all the way to a > >couple > >> of years ago. The really old ones should be closed IMO, and suggest > >to the > >> contributors to submit again if the issue(s) are still valid. > > There is generally a large difference in responsiveness between bugs and > enhancement requests. Most of the open PRs have been reviewed and are > waiting for feedback. The others are enhancement requests which typically > remain open until there is sufficient interest in implementing them. > > Yes it would be great to move faster on these. That needs more people > looking at them. Things are slowly improving - the total open issues is > trending downwards over time. > > Mark > > > > The > >newer > >> ones should be evaluated and feedback should be given to the > >contributors > >> You already "found" new contributors -- better spend some time > >"cultivating" > >> them than look for new ones who might end up stuck in that same > >situation. > >> > >> The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 -- > >is > >> from me, and it's only been a few days, so normally I wouldn't have > >said > >> anything at this point because it hasn't been "long enough" since I > >> submitted it. But then I saw this email and it made perfect sense > >for me to > >> chime in. > >> > >> It was very important for me to keep my PR as small and simple as > >possible, > >> so that it's easy to review and accept or reject. But there is no > >feedback > > > >Just for future reference, when you submit a PR it's easiest to review > >if you squash all of the commits into one rather than multiple > >commits. > > > >> whatsoever. I usually have more time to contribute on the weekends, > >so if > >> I'll get some feedback soon, I will hopefully be able to implement > >whatever > >> changes necessary on the weekend. If not, then another week goes by. > >> > >> Anyway, I really am not complaining here. Just providing a > >perspective from > >> "the other side". > >> > >> All the best, and keep up the good work! > > > >I appreciate the perspective and hope to hear more from new > >contributors :) Thanks again! > > > >> Igal > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >> For additional commands, e-mail: dev-h...@tomcat.apache.org > >> > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >For additional commands, e-mail: dev-h...@tomcat.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
