Author: markt
Date: Thu Jul  6 08:42:29 2017
New Revision: 1800992

URL: http://svn.apache.org/viewvc?rev=1800992&view=rev
Log:
Fix a FindBugs nag and add an explanatory comment.

Modified:
    tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java

Modified: tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java?rev=1800992&r1=1800991&r2=1800992&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java Thu Jul  
6 08:42:29 2017
@@ -60,7 +60,10 @@ public class JmxRegistry {
         // create registry
         registry = new JmxRegistry();
         registry.baseOname = baseOn;
-        registryCache.putIfAbsent(channel.getName(), registry);
+        // It doesn't matter if existing object gets over-written. This object
+        // holds minimal state and that state will be the same for all objects
+        // created for the same channel.
+        registryCache.put(channel.getName(), registry);
         return registry;
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to