Author: markt Date: Tue Jul 18 09:54:15 2017 New Revision: 1802266 URL: http://svn.apache.org/viewvc?rev=1802266&view=rev Log: Add clarifying comment
Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/Request.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/Request.java?rev=1802266&r1=1802265&r2=1802266&view=diff ============================================================================== --- tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/Request.java (original) +++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/Request.java Tue Jul 18 09:54:15 2017 @@ -2915,6 +2915,10 @@ public class Request implements org.apac partsParseException = e; } } finally { + // This might look odd but is correct. setParseFailedReason() only + // sets the failure reason if none is currently set. This code could + // be more efficient but it is written this way to be robust with + // respect to changes in the remainder of the method. if (partsParseException != null || !success) { parameters.setParseFailedReason(FailReason.UNKNOWN); } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org