svn commit: r1815459 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

[markt]

Author: markt
Date: Thu Nov 16 14:35:28 2017
New Revision: 1815459

URL: http://svn.apache.org/viewvc?rev=1815459&view=rev
Log:
Follow-up to r1815451
Review from kkolinko

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?rev=1815459&r1=1815458&r2=1815459&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Thu 
Nov 16 14:35:28 2017
@@ -260,9 +260,7 @@ public class NioBlockingSelector {
         }
 
         public boolean events() {
-            boolean result = false;
             Runnable r = null;
-            result = (events.size() > 0);
 
             /* We only poll and run the runnable events when we start this
              * method. Further events added to the queue later will be delayed
@@ -277,12 +275,12 @@ public class NioBlockingSelector {
              * which will kill a lot of time, and greatly affect performance of
              * the poller loop.
              */
-            for (int i = 0, size = events.size(); i < size && (r = 
events.poll()) != null; i++) {
+            int size = events.size();
+            for (int i = 0; i < size && (r = events.poll()) != null; i++) {
                 r.run();
-                result = true;
             }
 
-            return result;
+            return (size > 0);
         }
 
         @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org