https://bz.apache.org/bugzilla/show_bug.cgi?id=61795
Bug ID: 61795
Summary: Make JASPIC callback handler class configurable via a
property of the authenticator
Product: Tomcat 8
Version: 8.5.23
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: lazar.kirc...@gmail.com
Target Milestone: ----
As discussed in the mailing list, it could be useful to provide a property of
the authenticator with which to specify the name of a custom JASPIC callback
handler implementation.
This pull request https://github.com/apache/tomcat/pull/93 illustrates the
idea.
If we agree that this is OK and this will be the name of the property, I will
also add it to the documentation.
I have not included a test because I had some concerns. I want to test only the
instantiation of the Callback Handler instance, but this is done in a private
method. So I see several approaches:
- in such cases I sometimes make the method package private so that it can be
accessed by the test. However, I see that this is not an accepted practice in
the Tomcat code, so I do not want to use it
- call the method with reflection - I see that in some Tomcat tests reflection
is actually used
- use a lot of mocking and test via the authenticate method of a child class of
the AuthenticatorBase
- go for a test with a Tomcat instance and and a sample application and test
the whole scenario of JAPSIC authentication with custom callback handler
Which of these approaches do you prefer?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
