svn commit: r1817074 - in /tomcat/trunk/java/org/apache/catalina/tribes/transport: bio/MultipointBioSender.java nio/ParallelNioSender.java

[markt]

Author: markt
Date: Mon Dec  4 09:03:06 2017
New Revision: 1817074

URL: http://svn.apache.org/viewvc?rev=1817074&view=rev
Log:
Spotbugs fixes (rank >=16) in tribes.transport
Reformat so Spotbugs can determine the exceptions are ignored deliberately.

Modified:
    
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java
    
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java?rev=1817074&r1=1817073&r2=1817074&view=diff
==============================================================================
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java
 Mon Dec  4 09:03:06 2017
@@ -120,13 +120,21 @@ public class MultipointBioSender extends
 
     @Override
     public synchronized void disconnect() {
-        try {close(); }catch (Exception x){/* Ignore */}
+        try {
+            close();
+        } catch (Exception x) {
+            // Ignore
+        }
         setConnected(false);
     }
 
     @Override
     public void finalize() throws Throwable {
-        try {disconnect(); }catch ( Exception e){/* Ignore */}
+        try {
+            disconnect();
+        } catch (Exception e) {
+            // Ignore
+        }
         super.finalize();
     }
 

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java?rev=1817074&r1=1817073&r2=1817074&view=diff
==============================================================================
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
 Mon Dec  4 09:03:06 2017
@@ -116,7 +116,11 @@ public class ParallelNioSender extends A
                 throw cx;
             }
         } catch (Exception x ) {
-            try { this.disconnect(); } catch (Exception e) {/*Ignore*/}
+            try {
+                this.disconnect();
+            } catch (Exception e) {
+                // Ignore
+            }
             if ( x instanceof ChannelException ) throw (ChannelException)x;
             else throw new ChannelException(x);
         }
@@ -320,7 +324,11 @@ public class ParallelNioSender extends A
     @Override
     public synchronized void disconnect() {
         setConnected(false);
-        try {close(); }catch (Exception x){/*Ignore*/}
+        try {
+            close();
+        } catch (Exception x) {
+            // Ignore
+        }
     }
 
     @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org