svn commit: r1817244 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

[markt]

Author: markt
Date: Tue Dec  5 22:15:16 2017
New Revision: 1817244

URL: http://svn.apache.org/viewvc?rev=1817244&view=rev
Log:
Fix some SpotBugs (rank <=16) issues
Mark in/out as transient since serialization is primarily used to expose values 
- e.g. via JMX.
I did look at removing serialization but that ultimately impacted the 
ServerCookie representation that is helpful to have exposed via JMX.

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
    tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java?rev=1817244&r1=1817243&r2=1817244&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java Tue Dec  5 
22:15:16 2017
@@ -134,8 +134,9 @@ public final class ByteChunk implements
     // How much can it grow, when data is added
     private int limit=-1;
 
-    private ByteInputChannel in = null;
-    private ByteOutputChannel out = null;
+    // transient as serialization is primarily for values via, e.g. JMX
+    private transient ByteInputChannel in = null;
+    private transient ByteOutputChannel out = null;
 
     /**
      * Creates a new, uninitialized ByteChunk object.

Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java?rev=1817244&r1=1817243&r2=1817244&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Tue Dec  5 
22:15:16 2017
@@ -81,8 +81,9 @@ public final class CharChunk implements
     // maximum amount to be cached
     private int limit=-1;
 
-    private CharInputChannel in = null;
-    private CharOutputChannel out = null;
+    // transient as serialization is primarily for values via, e.g. JMX
+    private transient CharInputChannel in = null;
+    private transient CharOutputChannel out = null;
 
     private boolean optimizedWrite=true;
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org