Author: markt
Date: Wed Dec 13 13:34:20 2017
New Revision: 1818014
URL: http://svn.apache.org/viewvc?rev=1818014&view=rev
Log:
Fix SpotBugs casting warning.
Simplify by casting directing to ServiceRef given that an 'instance of' test
immediately precedes the first cast.
Modified:
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java
Modified:
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java?rev=1818014&r1=1818013&r2=1818014&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java
(original)
+++
tomcat/trunk/java/org/apache/naming/factory/webservices/ServiceRefFactory.java
Wed Dec 13 13:34:20 2017
@@ -33,7 +33,6 @@ import javax.naming.Context;
import javax.naming.Name;
import javax.naming.NamingException;
import javax.naming.RefAddr;
-import javax.naming.Reference;
import javax.naming.spi.ObjectFactory;
import javax.wsdl.Definition;
import javax.wsdl.Port;
@@ -70,7 +69,7 @@ public class ServiceRefFactory implement
throws Exception {
if (obj instanceof ServiceRef) {
- Reference ref = (Reference) obj;
+ ServiceRef ref = (ServiceRef) obj;
// ClassLoader
ClassLoader tcl =
@@ -236,13 +235,13 @@ public class ServiceRefFactory implement
}
// Use handler
- if (((ServiceRef) ref).getHandlersSize() > 0) {
+ if (ref.getHandlersSize() > 0) {
HandlerRegistry handlerRegistry = service.getHandlerRegistry();
List<String> soaproles = new ArrayList<>();
- while (((ServiceRef) ref).getHandlersSize() > 0) {
- HandlerRef handlerRef = ((ServiceRef) ref).getHandler();
+ while (ref.getHandlersSize() > 0) {
+ HandlerRef handlerRef = ref.getHandler();
HandlerInfo handlerInfo = new HandlerInfo();
// Loading handler Class
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
