On 14 December 2017 at 15:20, Mark Thomas <ma...@apache.org> wrote: > On 14/12/17 13:18, Konstantin Kolinko wrote: >> Hi, Mark! >> >> To dev@tomcat, cc: general@gump. >> >> >> The result of this change is that Gump building Tomcat downloads >> tar.gz for Commons-Daemon from mirrors. > > Drat. That wasn't the intention at all. > > <snip/> > >> The "mvn package" command used by Gump does not build the src.tar.gz file. >> >> The file can be built by "mvn assembly:single" command, [4] >> but HOWTO-RELEASE.txt file does not mention it so I wonder what is >> actually used by Commons Daemon here. > > The command 'mvn deploy -Prelease' creates it. I suspect that isn't > appropriate for Gump.
FTR: You can add the following options to deploy to target/deploy and not sign the artifacts: -Ptest-deploy -Dgpg.skip Documented here: http://commons.apache.org/releases/prepare.html#Create_the_Release_Candidate >> So this can be fixed by updating Gump configuration for commons-daemon to do >> <mvn3 goal="assembly:single" /> and >> <jar name="daemon/target/commons-daemon-[0-9]*[0-9T]-native-src.tar.gz" >> id="native-distro" /> >> >> >> Alternatively, a question is whether the "deploy" target in Tomcat >> actually has a need to copy the *.tar.gz files to CATALINA_HOME/bin/. >> Those source file are needed when redistributing Tomcat, but they are >> not actually needed when running it. > > Good point. > > The Windows binaries are only copied to /bin for the dist-static target. > I can't see a reason not to treat the *.tar.gz src files the same way. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@gump.apache.org > For additional commands, e-mail: general-h...@gump.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
