https://bz.apache.org/bugzilla/show_bug.cgi?id=57434
--- Comment #5 from Tomas Hofman <thof...@redhat.com> --- Sorry for not elaborating before - in fact my main motivation was that currently the parseExpressionString() method can throw a NPE because of the race, which breaks the request processing. Moreover when the NPE occurs, the mBypassCache flag is not reset to false by the calling method Evaluator#validate() and that affects later calls. The patch seemed like a safe solution to prevent the NPE. The caching could still be affected by the race condition, but that seemed like a smaller problem. Passing the flag as a method parameter would be ideal. Perhaps an overloaded method with an extra parameter could be introduced while the old one is kept, to stay backward compatible in case someone is calling the methods directly. I opened a PR in that regard in our fork: https://github.com/jboss/jboss-jstl-api_spec/pull/16/files (I overloaded also convertStaticValueToExpectedType(), which is too using the flag.) I understand the reluctance though. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
