On 09/04/18 09:26, Mark Thomas wrote: > On 21/03/18 13:00, Coty Sutherland wrote: >> On Tue, Mar 20, 2018 at 4:07 PM, Mark Thomas <ma...@apache.org> wrote:
<snip> >>> Having seen some of the messages for the tomcat-training repo what are >>> people's thoughts? >> >> I have a couple small things. >> >> 1) The third block's formatting looks weird on my end. Example: >> >> "The following commit(s) were added to refs/heads/master by this push: >> new b13e925 First draft of logging module >> b13e925 is described below" >> >> I'm not sure the first few lines are necessary (the automated message >> bit and repository link), so they could be removed/cleaned up. > > This is a common / standard format used across all ASF git repos. I > suspect there are usage styles (pushes of a large number of commits) > where this makes more sense. > >> 2) Can we add a link to the commit somehow so that it closer resembles >> the svn commit emails? > > I think we can ask infra for this. Is this a blocker for us to migrate? Infra pointed me towards this file: https://github.com/apache/infrastructure-puppet/blob/deployment/modules/gitbox/files/asfgit/git_multimail.py and indicated that they would be receptive to patches. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
