GitHub user koraktor opened a pull request:
https://github.com/apache/tomcat/pull/108
Improve undeployment in parallel deployment scenario
Main reason for this pull request is to improve automatic undeployment of
applications when using common version numbers, e.g. `application##1.2.3`.
Currently, `HostConfig#checkUndeploy()` uses plain sorting of the context
names without any special handling of the version identifier. When having a
version `1.0.9` deployed, deploying `1.0.10` will lead to immediate
undeployment of `1.0.10` because the ordering is wrong.
This change introduces `ContextName#compareTo()` which knows how to handle
commons version numbers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/koraktor/tomcat hostconfig-undeploy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit d370ec29c413dae458d2d10268e4d64f9a0e1526
Author: Sebastian Staudt <koraktor@...>
Date: 2017-12-13T19:18:34Z
Optimize HostConfig#checkUndeploy()
This short-circuits the creation of the SortedSet for the webapp
names if a maximum of one app is running.
commit 470852661942533b745fce6cddf8a4551d391989
Author: Sebastian Staudt <koraktor@...>
Date: 2018-04-24T22:09:39Z
Implement ContextName#compareTo()
This allows to undeploy old versions in a parallel deployment
scenario when using common version numbers, e.g. SemVer.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
