DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40966>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40966

           Summary: Socket descriptor checks on windows are incorrect
           Product: Tomcat 5
           Version: 5.0.0
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Native:JK
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: [EMAIL PROTECTED]


There are socket descriptor validity checks in ajp_reset_endpoint and ajp_done
(ajp_common.c) that don't use the IS_VALID_SOCKET macro, but rather do a sd > 0
check for validity.

On XP/Visual Studio 2005 (at least), SOCKET is an unsigned, which means sd > 0
always succeeds.
This doesn't break anything at the moment, since the subsequent code executed
correctly checks for invalid sockets before attempting to close them.

Patch is attached to correct this, as well as add a bit more debug logging
around the AJP responses.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to