Author: markt
Date: Mon Sep 3 10:52:16 2018
New Revision: 1839935
URL: http://svn.apache.org/viewvc?rev=1839935&view=rev
Log:
On balance, I think keeping these methods separate is the better option due to:
- easier to follow code
- simpler maintenance
- subtle differences between blocking/non-blocking that may be lost / become
less obvious if combined
- ability for sub-classes to over-ride
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java?rev=1839935&r1=1839934&r2=1839935&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Mon Sep
3 10:52:16 2018
@@ -399,8 +399,6 @@ public abstract class SocketWrapperBase<
* - To enable a marginally more efficient implemented for blocking
* writes which do not require the additional checks related to the
* use of the non-blocking write buffer
- * TODO: Explore re-factoring options to remove the split into
- * separate methods
*/
if (block) {
writeBlocking(buf, off, len);
@@ -448,8 +446,6 @@ public abstract class SocketWrapperBase<
* - To enable a marginally more efficient implemented for blocking
* writes which do not require the additional checks related to the
* use of the non-blocking write buffer
- * TODO: Explore re-factoring options to remove the split into
- * separate methods
*/
if (block) {
writeBlocking(from);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
